Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a manifest in the built result when packing charms and bundles. #281

Merged
merged 5 commits into from Apr 14, 2021
Merged

Include a manifest in the built result when packing charms and bundles. #281

merged 5 commits into from Apr 14, 2021

Conversation

facundobatista
Copy link
Contributor

@facundobatista facundobatista commented Apr 5, 2021 •
edited

This is a little too big branch, but a lot of it are repetitive test changes (because Builder now receives the config).

Fixes #273.

cjp256
cjp256 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facundobatista facundobatista marked this pull request as draft April 7, 2021 13:22
@facundobatista facundobatista mentioned this pull request Apr 7, 2021
Merged
@facundobatista facundobatista marked this pull request as ready for review April 12, 2021 11:36
@facundobatista facundobatista merged commit fe2d065 into canonical:master Apr 14, 2021
@jnsgruk jnsgruk mentioned this pull request Apr 15, 2021
Closed
@facundobatista facundobatista deleted the produce-manifest-2 branch June 28, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens left review comments

@cmatsuoka cmatsuoka cmatsuoka approved these changes

@cjp256 cjp256 cjp256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a manifest at build time with building information
4 participants
@facundobatista @cmatsuoka @sergiusens @cjp256