Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charmcraft/jujuignore.py: Allow extending the list of patterns. #99

Merged
merged 4 commits into from
Aug 13, 2020
Merged

charmcraft/jujuignore.py: Allow extending the list of patterns. #99

merged 4 commits into from
Aug 13, 2020

Commits on Aug 13, 2020

  1. charmcraft/jujuignore.py: Allow extending the list of patterns.

    @jameinel
    jameinel committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    5257247 View commit details
    Browse the repository at this point in the history

  2. charmcraft/commands/build.py: review feedback 

    Cleanup a bunch of small issues found in review. (whitespace, bad
imports, etc.)
    @jameinel
    jameinel committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    f42421e View commit details
    Browse the repository at this point in the history

  3. charmcraft/commands/build.py: support utf-8 

    Add tests for _load_jujuignore and its behavior around default ignores
and extending those ignores with the content of .jujuignore, as well as
clarify the encoding of the file.
    @jameinel
    jameinel committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    3e3d525 View commit details
    Browse the repository at this point in the history

  4. fix import paths

    @jameinel
    jameinel committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    e803844 View commit details
    Browse the repository at this point in the history