Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepdiff>6.2.1 causes error: can't find Rust compiler #42

Closed
DnPlas opened this issue Mar 17, 2023 · 3 comments · Fixed by #46
Closed

deepdiff>6.2.1 causes error: can't find Rust compiler #42

DnPlas opened this issue Mar 17, 2023 · 3 comments · Fixed by #46

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Mar 17, 2023

It seems like charms installing chisme's deepdiff dependency will end in error with the following message:

::    ::             running build_rust                                                                                          
::    ::             error: can't find Rust compiler                                                                             
::    ::                                                                                                                         
::    ::             If you are using an outdated pip version, it is possible a prebuilt wheel is available for this package but pip is not able to install from it. Installing from the wheel would avoid the need for a Rust compiler.

Workaround

pin deepdiff==6.2.1 in charms

Solution

pin deepdiff in the setup.cfg file
@ca-scribner
Copy link
Contributor

If we can pin this here that's great and I love the solution. I dont think we're expecting big improvements in deepdiff :)

If we cannot pin it, I say we remove the one usage. We don't use that part of chisme atm iirc, and could find a workaround if needed

@DnPlas
Copy link
Contributor Author

DnPlas commented Mar 17, 2023

@ca-scribner let's pin it and find a workaround later if needed? We use it in a very very very small part of chisme.

@ca-scribner
Copy link
Contributor

yeah if pinning is solving this problem, I like pinning it

DnPlas added a commit that referenced this issue Mar 17, 2023
@DnPlas
fix: pin deepdiff==6.2.1 to avoid build time error
067a8d2 
There is a dependency in deepdiff (orjson) which requires rust
to be present in the charm when installing pip packages, causing
an error if it's not. To avoid the error, we can pin deepdiff to
version 6.2.1 which has a dependency tree that does not require rust.

Fixes #42
@DnPlas DnPlas mentioned this issue Mar 17, 2023
Merged
ca-scribner pushed a commit that referenced this issue Mar 17, 2023
@DnPlas
fix: pin deepdiff==6.2.1 to avoid build time error (#46)
1af1851 
There is a dependency in deepdiff (orjson) which requires rust
to be present in the charm when installing pip packages, causing
an error if it's not. To avoid the error, we can pin deepdiff to
version 6.2.1 which has a dependency tree that does not require rust.

Fixes #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pin deepdiff==6.2.1 to avoid build time error canonical/charmed-kubeflow-chisme
2 participants
@DnPlas @ca-scribner