Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add workflow to build, scan and test a ROCK #26

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Nov 30, 2023

Add reusable workflow to build, scan and test a ROCK. This workflow comes from the kubeflow-rocks repo. I only renamed the input from rock to rock-dir since it represents better what its value should be.

Refs canonical/bundle-kubeflow#692

@orfeas-k
Copy link
Contributor Author

Once this is merged, we should update kubeflow-rocks on_pull_request.

@orfeas-k
Copy link
Contributor Author

I 'm also OK with renaming the input back to rock since we already use this name in build_and_scan_rock.yaml.

ca-scribner
ca-scribner previously approved these changes Dec 1, 2023
@ca-scribner
Copy link
Contributor

regarding renaming the inputs, I like rock-dir more myself mainly because I suspect in future we'll also have workflows that build a rock and pass the actual rock (x.rock), so that feels like a better use of the rock input

Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@orfeas-k orfeas-k merged commit 34d8feb into main Dec 4, 2023
@orfeas-k orfeas-k deleted the kf-5024-feat-integrate-rock branch December 4, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants