Increase trivy timeout #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2024
orfeas-k
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Good catch Michal, approving since that's a fair estimate including future GPU ROCKs as you let me know. We decided to have a comment in the issue canonical/data-science-stack#52 so if we see that 50 minutes is much longer than needed after all, we 'll readjust the timeout here to make sure that this catches cases where something is actually stuck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the Trivy timemout for scanning images from default 5 mins to 50 mins. This change is needed as some ROCKs (e.g. pytorch-cpu in this PR) takes time to scan (The bigger GPU ones will take even longer). This change was tested in this PR run