Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added badges to README #39

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Added badges to README #39

merged 1 commit into from
Mar 7, 2024

Conversation

a-velasco
Copy link
Contributor

Issue

Repo status is not displayed in the Charm Engineering Releases page.

Solution

Added status badges:

  • Publish
  • Tests

Comment on lines +2 to +3
[![Publish](https://github.com/canonical/charmed-mysql-rock/actions/workflows/publish.yaml/badge.svg)](https://github.com/canonical/charmed-mysql-rock/actions/workflows/publish.yaml)
[![Tests](https://github.com/canonical/charmed-mysql-rock/actions/workflows/integration.yaml/badge.svg)](https://github.com/canonical/charmed-mysql-rock/actions/workflows/integration.yaml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, we need to sync workflows names between MySQL and PostgreSQL in the future.
Naming here is correct, but PostgreSQL it is release and not publish...

Copy link
Contributor Author

@a-velasco a-velasco Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taurus-forever Agreed - I'd say the names need to sync between all the data platform repos, since there are a lot of inconsistencies there (and the badge names cannot be hardcoded afaik; they will take either the name field of the workflow file or its path). I'll create a ticket for this.

@a-velasco a-velasco requested a review from paulomach March 6, 2024 10:23
@a-velasco a-velasco merged commit 54549ba into 8.0-22.04 Mar 7, 2024
3 of 10 checks passed
@a-velasco a-velasco deleted the status-badges branch March 7, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants