Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests mkdir put #528

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Fix broken tests mkdir put #528

merged 4 commits into from
Jun 1, 2023

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jun 1, 2023

Description

Some tests were relying on the old Put behaviour of creating the parent directory of a path if a Put failed. We have removed it in favor of a clear error but now tests are failing because of that.

Resolved issues

Fixes: #527

Documentation

N/A

Tests

All tests are now in the green both legacy and remote

Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it fixes a critical bug, let's land it.
Although I'd change a few bits in this, but this is not critical.

I'm taking liberty of landing it so everybody can rebase their work on this.

@kissiel kissiel merged commit 7989408 into main Jun 1, 2023
7 checks passed
@kissiel kissiel deleted the fix_broken_tests_mkdir_put branch June 1, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metabox tests are failing due to missing parent dir
2 participants