-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial provider #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question inline, and also one request: as I pointed out in Jira, I need a job that uses an environment variable (with a default set), because of this section in the tutorial.
So basically a job that runs something like
echo ${TUTO:-default}
so that it still outputs something if no env var is set, but behaves differently if an env var is set (in launcher, in my case).
Another request for this PR: the tutorial needs to be available from an installed snap, so the snapcraft.yaml recipes need to package it, the same way we package |
724eaf4
to
6bb2f1e
Compare
The base tutorial uses jobs and test plan from this provider as part of the introduction to Checkbox, so it needs to be present in the snap.
6bb2f1e
to
1102400
Compare
I've made the modifications I talked about in my review, and a few other things. I've also added this provider to the Finally, regarding the jobs, I'm wondering if we should drop the |
Revisiting this:
|
I've done the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in docs/ look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking up the branch!
One question below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't officially +1 this PR as I opened it, but big +1 from me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, I have to approve my own changes! Thank you GitHub!
Description
This PR introduces a Checkbox Tutorial Provider.
The included test plan contains various jobs that yield different outcomes, including outcomes that are results of failing resources or dependent jobs.
Tested throughout manually 👨🔧
Resolves: CHECKBOX-750