Carryover codecov coverage #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flagging is basically a way to give a category to unittests (grouping them together)
Given that we have a monorepo, we do not run all tests every time. carryover makes codecov use any previous run as an oracle if a submission is missing coverage data for an existing flag
Codecov Report
@@ Coverage Diff @@
## main #680 +/- ##
===========================================
- Coverage 58.67% 32.05% -26.62%
===========================================
Files 103 302 +199
Lines 14430 35156 +20726
Branches 2374 6141 +3767
===========================================
+ Hits 8467 11270 +2803
- Misses 5632 23362 +17730
- Partials 331 524 +193
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
The drop in coverage of this PR is "fake", last run on main only executed checkbox-ng tests, and due to the missing carryover, now codecov thinks that we have a 5x% coverage on main |
kissiel
suggested changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given that we have a monorepo, we have several "parts" that are independent in the same spot. Every time a change is pushed to a pr or main, if a part was changed, it is tested. Once a part is tested the coverage results are pushed to codecov.io.
This fixes this issue by enabling carryover and flagging the parts. Carryover basically means that if a flag (part) is not updated in a submission, the previous value is used instead. Flags are how codecov identifies the parts, this creates one per part + one for all
unittestsResolved issues
The issue that we are having is that if a part is not tested in a submission (for example, because it was not changed), codecov "forgets" it existed right now, leading to the coverage values that are not reflecting of reality.
Documentation
This adds a new flag per part, this should make the output more readable without any need for additional documentation.
Tests
See the codecov bot comment to get to the dashboard, it should now have a "flags" section that lists the coverage of each part