Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the config chains scenario in metabox local-only #691

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

kissiel
Copy link
Contributor

@kissiel kissiel commented Aug 29, 2023

This should never have run via remote because:

  • the configs on the controller are not taken into account
  • the agent runs as root, so configs for the ubuntu user are pointless

There is more that we can improve in this test, but this patch at least fixes the metabox runs.

This should never have run via remote because:
- the configs on the controller are not taken into account
- the agent runs as root, so configs for the `ubuntu` user are pointless

There is more that we can improve in this test, but this patch at least
fixes the metabox runs.
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kissiel kissiel merged commit 2f03de6 into main Sep 4, 2023
10 checks passed
@kissiel kissiel deleted the metabox-chains-scenario-improvements branch September 4, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants