Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit tox run to the env of the current matrix (infra) #726

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Sep 14, 2023

Description

Currently tox is run on a machine without limiting the environment it is meant to cover. When this is done, tox selects any environment that it is able to run so, if an image contains more than a version of python, tox will in a single action for multiple versions of python.

See for example this action run, the python3.6 environment contains both python3.6 and python3.8.

This makes the output very long and hard to read, the failure here is at line 1399, that would be at the end of the log, but it is not because right after 3.6, 3.8 is tested. This also means that tests are run multiple times with the same python, wasting a lot of resources/time.

Resolved issues

Fixes: CHECKBOX-870

Documentation

N/A

Tests

N/A

@Hook25 Hook25 marked this pull request as draft September 14, 2023 13:54
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #726 (914a100) into main (ef79796) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   32.97%   33.00%   +0.02%     
==========================================
  Files         302      302              
  Lines       35170    35170              
  Branches     6144     6144              
==========================================
+ Hits        11598    11608      +10     
+ Misses      23020    23013       -7     
+ Partials      552      549       -3     
Flag Coverage Δ
checkbox-ng 60.93% <ø> (+0.04%) ⬆️
checkbox-support 49.20% <ø> (+0.02%) ⬆️
provider-base 1.93% <ø> (ø)
provider-certification-client 57.14% <ø> (ø)
provider-gpgpu 57.14% <ø> (ø)
provider-iiotg 100.00% <ø> (ø)
provider-resource 9.59% <ø> (ø)
provider-sru 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@Hook25 Hook25 marked this pull request as ready for review September 14, 2023 14:14
Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is the most elegant way to do it.

the setup-python action requires a dotted version string, so we can't use one version string type, and we have to have this mapping.

Thanks for the patch and clarification.
+1

@Hook25 Hook25 merged commit 5cbe139 into main Sep 14, 2023
45 checks passed
@Hook25 Hook25 deleted the limit_tox_runs_matrix branch September 14, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants