Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: package names can be of length two #120

Merged
merged 10 commits into from
Mar 8, 2024
Merged

fix: package names can be of length two #120

merged 10 commits into from
Mar 8, 2024

Commits on Feb 8, 2024

  1. feat: package names can be of length two 

    This commit adds support for package names with a minimum length of two.
Previously chisel only supported a minimum length of 3. The limit on the
slice name is kept unchanged.

Fixes canonical#119.
    @rebornplusplus
    rebornplusplus committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0701528 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. test: inline struct definition in slice key tests

    @rebornplusplus
    rebornplusplus committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5a275f4 View commit details
    Browse the repository at this point in the history

  2. test: fix formatting

    @rebornplusplus
    rebornplusplus committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    8d85c30 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. test: simplify error comparison logic

    @rebornplusplus
    rebornplusplus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9d5fdbe View commit details
    Browse the repository at this point in the history

  2. refactor: fix formatting issues

    @rebornplusplus
    rebornplusplus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    604a00b View commit details
    Browse the repository at this point in the history

  3. refactor: add pkg and slice name expression string 

    Add pkg and slice name expression string variables to remove duplication
and increase test coverage.
    @rebornplusplus
    rebornplusplus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0f724ae View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. test: add more test data for ParseSliceKey

    @rebornplusplus
    rebornplusplus committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    be332e0 View commit details
    Browse the repository at this point in the history

  2. refactor: group the ParseSliceKey tests

    @rebornplusplus
    rebornplusplus committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    1f8cedf View commit details
    Browse the repository at this point in the history

  3. test: use proper values in test data

    @rebornplusplus
    rebornplusplus committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    eadd704 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Revert "refactor: add pkg and slice name expression string" 

    This reverts commit 0f724ae.
    @rebornplusplus
    rebornplusplus committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    662f331 View commit details
    Browse the repository at this point in the history