Fix chef module run failure when chef_license is set (#868)

Move chef_license from TPL_PATH_KEYS to TPL_KEYS as the chef license
setting is not a path but must be added to the client config template.
Fixes file or folder not found exception raised from ensure_dirs.

cloudinit/config/cc_chef.py

@@ -70,7 +70,6 @@
     'json_attribs',
     'pid_file',
     'encrypted_data_bag_secret',
-    'chef_license',
 ])
 CHEF_RB_TPL_KEYS = list(CHEF_RB_TPL_DEFAULTS.keys())
 CHEF_RB_TPL_KEYS.extend(CHEF_RB_TPL_BOOL_KEYS)
@@ -80,6 +79,7 @@
     'node_name',
     'environment',
     'validation_name',
+    'chef_license',
 ])
 CHEF_RB_TPL_KEYS = frozenset(CHEF_RB_TPL_KEYS)
 CHEF_RB_PATH = '/etc/chef/client.rb'

templates/chef_client.rb.tmpl

@@ -15,7 +15,7 @@ The reason these are not in quotes is because they are ruby
 symbols that will be placed inside here, and not actual strings...
 #}
 {% if chef_license %}
-chef_license          "{{chef_license}}"
+chef_license           "{{chef_license}}"
 {% endif%}
 {% if log_level %}
 log_level              {{log_level}}

tools/.github-cla-signers

@@ -51,3 +51,4 @@ WebSpider
 xiachen-rh
 xnox
 hamalq
+bmhughes