comments

canonical · Apr 2, 2024 · 92d91ec · 92d91ec
1 parent aec9035
commit 92d91ec
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/tests/unittests/net/test_dhcp.py b/tests/unittests/net/test_dhcp.py
@@ -1202,13 +1202,6 @@ def test_parse_lease_dump(self):
     @pytest.mark.parametrize(
         "lease, parsed",
         (
-            pytest.param(
-                """
-                fail
-                """,
-                {},
-                id="lease_has_no_keys",
-            ),
             pytest.param(
                 """
 
@@ -1250,6 +1243,7 @@ def test_parse_lease_dump_resilience(self, lease, parsed):
         with mock.patch("cloudinit.net.dhcp.util.load_binary_file"):
             Dhcpcd.parse_dhcpcd_lease(dedent(lease), "eth0")
 
+
     def test_parse_lease_dump_fails(self):
         def _raise():
             raise ValueError()
@@ -1261,6 +1255,15 @@ def _raise():
             with mock.patch("cloudinit.net.dhcp.util.load_binary_file"):
                 Dhcpcd.parse_dhcpcd_lease(lease, "eth0")
 
+        with pytest.raises(InvalidDHCPLeaseFileError):
+            with mock.patch("cloudinit.net.dhcp.util.load_binary_file"):
+                lease = dedent(
+                    """
+                    fail
+                    """
+                )
+                Dhcpcd.parse_dhcpcd_lease(lease, "eth0")
+
     @pytest.mark.parametrize(
         "lease_file, option_245",
         (