feat(azure): parse ProvisionGuestProxyAgent as bool (#5126)

canonical · Apr 5, 2024 · ffacae6 · ffacae6
1 parent 516fad6
commit ffacae6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/cloudinit/sources/helpers/azure.py b/cloudinit/sources/helpers/azure.py
@@ -1136,6 +1136,7 @@ def _parse_platform_settings_section(self, root):
         self.provision_guest_proxy_agent = self._parse_property(
             platform_settings,
             "ProvisionGuestProxyAgent",
+            parse_bool=True,
             default=False,
             required=False,
         )

diff --git a/tests/unittests/sources/test_azure.py b/tests/unittests/sources/test_azure.py
@@ -2827,13 +2827,21 @@ def test_read_azure_ovf_with_savable_type(self):
         self.assertTrue(cfg["PreprovisionedVm"])
         self.assertEqual("Savable", cfg["PreprovisionedVMType"])
 
-    def test_read_azure_ovf_with_proxy_guest_agent(self):
+    def test_read_azure_ovf_with_proxy_guest_agent_true(self):
         """The read_azure_ovf method should set ProvisionGuestProxyAgent
         cfg flag to True."""
         content = construct_ovf_env(provision_guest_proxy_agent=True)
         ret = dsaz.read_azure_ovf(content)
         cfg = ret[2]
-        self.assertTrue(cfg["ProvisionGuestProxyAgent"])
+        assert cfg["ProvisionGuestProxyAgent"] is True
+
+    def test_read_azure_ovf_with_proxy_guest_agent_false(self):
+        """The read_azure_ovf method should set ProvisionGuestProxyAgent
+        cfg flag to False."""
+        content = construct_ovf_env(provision_guest_proxy_agent=False)
+        ret = dsaz.read_azure_ovf(content)
+        cfg = ret[2]
+        assert cfg["ProvisionGuestProxyAgent"] is False
 
 
 @pytest.mark.parametrize(