upstream should handle cc_ renames

[ubuntu-server-builder]

This bug was originally filed in Launchpad as LP: #1075980

Launchpad details

affected_projects = []
assignee = harlowja
assignee_name = Joshua Harlow
date_closed = 2012-11-14T20:31:31.889567+00:00
date_created = 2012-11-07T14:54:16.438947+00:00
date_fix_committed = 2012-11-12T18:07:45.573230+00:00
date_fix_released = 2012-11-14T20:31:31.889567+00:00
id = 1075980
importance = medium
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1075980
milestone = None
owner = smoser
owner_name = Scott Moser
private = False
status = fix_released
submitter = smoser
submitter_name = Scott Moser
tags = []
duplicates = []

Launchpad user Scott Moser(smoser) wrote on 2012-11-07T14:54:16.438947+00:00

Previously, I have handled renames of config modules in the Ubuntu packaging.
However, that means that really just throws that maintenance onto the packager. It'd be much nicer if cloud-init handled it somehow. The specific motivation for this is [1]. If the packaging doesn't change to address it, the new "package-update-upgrade-install" would be run again as it has never been run before.

The things I'd like to have:

• ability to specify that

  • apt-update-upgrade was split into 2 pieces: apt-configure, package-update-upgrade-install
  • foo changed in name to bar

• it looks like semaphores can contain '-' in them, based on their name in the config. Also, the config is inconsistent even in itself with respect to usage of '_' or '-'. I'd like to be consistent in the config (config/cloud.cfg) and enforce that 'set_hostname' is the same as 'set-hostname'.

--
[1] https://code.launchpad.net/~harlowja/cloud-init/pkg-up-install-goodies/+merge/130019

[ubuntu-server-builder]

Launchpad user Scott Moser(smoser) wrote on 2012-11-07T18:53:29.728707+00:00

I talked with harlowja about this and we agreed that it makes sense to at least look at a 'cc_fixup' module that would run first, and it would go through and apply updates. psuedocode:
if module_ran("apt-update-upgrade"):
mark_ran("apt-configure", "package-update-upgrade-install")
if module_ran("foo-was-renamed-to-bar"):
mark_ran("bar")

Where 'mark_ran' might even put the cloud-init version that applied the change.

[ubuntu-server-builder]

Launchpad user Scott Moser(smoser) wrote on 2012-11-07T18:53:54.895911+00:00

it could also go through any semaphores with '-' in their name and canonicalize them.

[ubuntu-server-builder]

Launchpad user Joshua Harlow(harlowja) wrote on 2012-11-08T07:22:28.100017+00:00

https://code.launchpad.net/~harlowja/cloud-init/migrator-module/+merge/133409 should be doing this now also.

[ubuntu-server-builder]

Launchpad user Scott Moser(smoser) wrote on 2012-11-12T18:07:45.017429+00:00

this was fix-committed in revno 710.