Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_cfg not read on Oracle datasource #3938

Closed
ubuntu-server-builder opened this issue May 12, 2023 · 10 comments
Closed

system_cfg not read on Oracle datasource #3938

ubuntu-server-builder opened this issue May 12, 2023 · 10 comments
Labels
launchpad Migrated from Launchpad priority Fix soon

Comments

@ubuntu-server-builder
Copy link
Collaborator

This bug was originally filed in Launchpad as LP: #1956788

Launchpad details
affected_projects = []
assignee = aciba
assignee_name = Alberto Contreras
date_closed = None
date_created = 2022-01-07T18:20:57.658410+00:00
date_fix_committed = 2023-03-05T05:09:48.135335+00:00
date_fix_released = None
id = 1956788
importance = high
is_complete = False
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1956788
milestone = None
owner = falcojr
owner_name = James Falcon
private = False
status = fix_committed
submitter = falcojr
submitter_name = James Falcon
tags = ['sc-1414']
duplicates = []

Launchpad user James Falcon(falcojr) wrote on 2022-01-07T18:20:57.658410+00:00

In 2c52e6e , the order of reading network config was changed for Oracle due to initramfs needing to take lower precedence than the datasource. However, this also bumped system_cfg to a lower precedence than ds, which means that any network configuration specified in /etc/cloud will not be applied.

system_cfg should instead be moved above ds so network configuration in /etc/cloud takes precedence.

@ubuntu-server-builder ubuntu-server-builder added launchpad Migrated from Launchpad priority Fix soon labels May 12, 2023
@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Brett Holman(holmanb) wrote on 2022-02-15T21:54:34.768998+00:00

This bug is believed to be fixed in cloud-init in version 22.1. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Chad Smith(chad.smith) wrote on 2022-03-11T18:11:25.641679+00:00

This fix in Jammy 22.1-14-g2e17a0d6-0ubuntu1~22.04.1 also had an unintended side-effect where network would not get rendered due and newly launched instnaces on Jammy were unreachable due to
cloud-init networking being configured as disabled in Oracle images /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg.

This commit is being reverted for this release so it can be refactored to avoid the side-effect.
#1326

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user James Falcon(falcojr) wrote on 2022-04-27T13:47:44.211326+00:00

Every Oracle instance boots with /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg as it was probably intended to ensure only iSCSI configuration is used. While this seems unnecessary to me, there are currently no plans to change this, so I see no reason to keep this bug open.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Fabio Augusto Miranda Martins(fabio.martins) wrote on 2022-12-15T23:35:49.825539+00:00

CPC has worked on removing /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg from Oracle images and this is completed started with Images with build >=20221123

I just used our daily images to create 3 custom images with:

  • Jammy: 20221214
  • Focal: 20221214
  • Bionic: 20221205

And launched J/F/B bare-metal instances and I can validate this doesn't cause any issues and the networking is working well on all 3 releases:

https://pastebin.ubuntu.com/p/nX7dM7mQSQ/

I believe next step is to proceed with the change proposed by this LP.

As a reminder, as part of a post-install script, we'll need to remove /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg if it exists, so that we don't break network for existing instances when they upgrade cloud-init.

Marking back as triaged confirmed, since we removed /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg fropm the images, which prevented our work here.

EDIT: Marking as confirmed, as I can't mark as Triaged

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Alberto Contreras(aciba) wrote on 2023-02-13T10:11:35.456743+00:00

Being fixed in:

#1998
#2014

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Chad Smith(chad.smith) wrote on 2023-03-05T05:08:38.373951+00:00

Upstream commit landed for this feature 6b9bf7b

expected release cloud-init version 23.2. It'll publish sooner into 23.04 (Lunar) in a 23.1.1-## interim snapshot.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Chad Smith(chad.smith) wrote on 2023-03-05T05:09:41.194907+00:00

Related changeset in Lunar packaging to remove config artifacts across upgrade path on Oracle: #2046

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Fabio Augusto Miranda Martins(fabio.martins) wrote on 2023-03-06T12:46:03.771268+00:00

I see per the comments that this is being released to Lunar. Is there a plan to backport it to B / F / J?

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user James Falcon(falcojr) wrote on 2023-03-06T16:34:59.958139+00:00

Fabio, this one missed the 23.1 release, which is currently in the process of being SRUed. It will make if to F, J, and K (not B as it will be EOL) once 23.2 lands in about 3 months.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Alberto Contreras(aciba) wrote on 2023-03-09T11:01:31.247671+00:00

F, J, K PRs:

#2068
#2069
#2070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
launchpad Migrated from Launchpad priority Fix soon
Projects
None yet
Development

No branches or pull requests

1 participant