Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.13: Concerns about passlib maintenance #4791

Open
holmanb opened this issue Jan 22, 2024 · 3 comments
Open

Python 3.13: Concerns about passlib maintenance #4791

holmanb opened this issue Jan 22, 2024 · 3 comments
Labels
bug Something isn't working correctly

Comments

@holmanb
Copy link
Member

holmanb commented Jan 22, 2024 •
edited

Python 3.13 will release in September 2024. We added a passlib dependency to Python 3.13 recently in preparation for this release, per the upstream Python recommendation:

Deprecated since version 3.11, will be removed in version 3.13: The crypt module is deprecated (see PEP 594 for details and alternatives). The hashlib module is a potential replacement for certain use cases. The passlib package can replace all use cases of this module.

However, there is some concern about the maintenance status of passlib. Given the looming release date later in this year, and the activity in the upstream bug, we will want to keep an eye developments in that bug.

I just left a comment on the upstream passlib bug for this issue expressing cloud-init's interest in the outcomes of the issue.

Reference: passlib commits
@holmanb holmanb added bug Something isn't working correctly new An issue that still needs triage labels Jan 22, 2024
@blackboxsw blackboxsw removed the new An issue that still needs triage label Jan 24, 2024
@holmanb
Copy link
Member Author

holmanb commented Apr 12, 2024

Apparently Eli Collins is back and has a plan for supporting passlib - a 1.7.5 release is expected soon.

@TheRealFalcon
Copy link
Member

Sweet. Think we still need this bug?

@holmanb
Copy link
Member Author

holmanb commented Apr 12, 2024

Sweet. Think we still need this bug?

I was thinking we can close it once the next release gets published.

holmanb added a commit to holmanb/cloud-init that referenced this issue May 2, 2024
@holmanb
feat(crypt): Add openssl support for password hashing
5d66eff 
- If crypt module is not available prefer openssl, otherwise passlib[1].
- Refactor multiple crypt callsites to a single Python module.
- Add tests to verify openssl / passlib / crypt behavior.

[1] canonical#4791
holmanb added a commit to holmanb/cloud-init that referenced this issue May 2, 2024
@holmanb
fix(crypt): Add salt to passlib calls
26e3137 
- Refactor multiple crypt callsites to a single Python module.
- Add tests to verify standardized behavior between passlib and crypt.

[1] canonical#4791
holmanb added a commit to holmanb/cloud-init that referenced this issue May 2, 2024
@holmanb
fix(crypt): Add salt to passlib calls
f8e5dc8 
- Refactor multiple crypt callsites to a single Python module.
- Add tests to verify standardized behavior between passlib and crypt.

[1] canonical#4791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheRealFalcon @blackboxsw @holmanb