Include dpkg frontend lock in APT_LOCK_FILES (SC-650) #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealFalcon
changed the title
blackboxsw
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Thanks for the James. Reasonable to add yet another apt lock file check without additional unittests as we already have coverage for this functionality.
I was able to continue to validate that desired behavior and retries is working by camping on an apt upgrade in a terminal and running cloud-init modules --mode=final with userdata which tries to install packages
2021-12-15 03:21:07,618 - debian.py[DEBUG]: Waiting for apt lock
2021-12-15 03:21:17,631 - debian.py[DEBUG]: apt lock available
2021-12-15 03:21:17,631 - subp.py[DEBUG]: Running command ['eatmydata', 'apt-get', '--option=Dpkg::Options::=--force-confold', '--option=Dpkg::options::=--force-unsafe-io', '--assume-yes', '--quiet', 'update'] with allowed return codes [0] (shell=False, capture=False)
This was referenced May 11, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Context
#1034 (comment)
#1034 (comment)
I also included a link to the first comment in a code comment.