Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NetworkManagerActivator error #1180

Closed
wants to merge 1 commit into from
Closed

Conversation

wzfei012
Copy link

Load connection before execute "nmcli connection up"。By the way, reload network connections maybe required .

@wzfei012 wzfei012 closed this Jan 11, 2022
@wzfei012 wzfei012 reopened this Jan 11, 2022
@wzfei012
Copy link
Author

I tried to configure network-scripts on my machine,but cloud-init does not effect at all 。Then I found NM_CONTROLLED was set default to "no"。When I set NM_CONTROLLED to "yes" and try again, it still does not work. However,the scripts at /etc/sysconfig/network-scripts are all right.
I found while Bring up interface using nmcli,new connection has to be load first.
Sometimes,existing connections will effect new connections which we hope to configure.So I reload network at last

@TheRealFalcon TheRealFalcon self-assigned this Jan 12, 2022
@TheRealFalcon
Copy link
Member

Looks like this solution is sysconfig specific. I'm not very knowledgeable of sysconfig. Is there a way to load the connection without referencing the specific file (i.e., in a non-sysconfig specific way)? If not, can you first check to see if the file exists before attempting to load it?

Also, why do we need to completely take down networking in order to bring up a new interface? We don't want to take down existing connections if we don't have to.

@otubo
Copy link
Contributor

otubo commented Jan 20, 2022

This PR seems to fix the problem we're having on this bug: https://bugzilla.redhat.com/show_bug.cgi?id=2036060

@wzfei012 what's the status on making it move forward? I see it's been 8 days since last comment. I can take over and rework a bit if you will.

Thanks!

@anhvoms
Copy link
Contributor

anhvoms commented Jan 30, 2022

This PR seems to fix the problem we're having on this bug: https://bugzilla.redhat.com/show_bug.cgi?id=2036060

@wzfei012 what's the status on making it move forward? I see it's been 8 days since last comment. I can take over and rework a bit if you will.

Thanks!

@otubo I don't have access to that bug. Can you add me to the bug?

@tyll
Copy link

tyll commented Feb 2, 2022

all commands except the nmcli connection load and nmcli connection up commands should not be necessary. The commit message does not explain the reasons the other commands are needed. What should be accomplished with this patch?

@github-actions
Copy link

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Feb 17, 2022
@github-actions github-actions bot closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-pr Pull request is stale; will be auto-closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants