schema: add json defs for modules e-install (SC-651) #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealFalcon
commented
Apr 3, 2022
TheRealFalcon
changed the title
* cc_emit_upstart (removal) * cc_fan * cc_final_message * cc_foo * cc_growpart * cc_grub_dpkg * cc_install_hotplug
TheRealFalcon
force-pushed
the
schema-e-g
branch
from
7fbf17b
to
cc21bf5
Compare
blackboxsw
requested changes
Apr 5, 2022
cloudinit/config/cc_fan.py
Outdated
| @@ -18,32 +22,35 @@ | |||
| - write ``config_path`` with the contents of the ``config`` key | |||
There was a problem hiding this comment.
Let's also document that ubuntu-fan package will be installed if absent.
|
|
||
| MODULE_DESCRIPTION = """\ | ||
| This module configures the final message that cloud-init writes. The message is | ||
| specified as a jinja template with the following variables set: |
There was a problem hiding this comment.
Should we also document that this module writes /var/lib/cloud/instance/boot-finished on exit. systemd units could rely on the presence of this file to trigger other units to start (if they don't want to use cloud-init status --wait)
|
Pushed next set from comments.
I think I added warnings for everything here |
blackboxsw
approved these changes
Apr 5, 2022
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Removed 'cc_emit_upstart' entirely. According to https://upstart.ubuntu.com/ , the only place we'll see upstart anymore is trusty and RHEL 6, neither of which will ever see a new upstream change