net-convert: use yaml.dump for debugging python NetworkState obj #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly a unittest fix, as most systems which want to render systemd-networkd config artifacts already have /etc/systemd/network. Avoid calling os.dirname on self.network_conf_dir because then we only create the parent directory /etc/systemd and cannot write /etc/systemd/network/10-cloud-init-eth0.network
When debugging python's NetworkState intance we cannot use safeyaml.dumps because that leverages the yaml.SafeDumper which does not allow rendering python objects. Use yamls.dump instead. LP: #1975907
aciba90
approved these changes
May 30, 2022
|
|
||
| util.ensure_dir(os.path.dirname(fp_nwkd)) | ||
| util.ensure_dir(network_dir) |
holmanb
approved these changes
May 31, 2022
| """Assert proper output-kind artifacts are written.""" | ||
| network_data = tmpdir.join("network_data") | ||
| network_data.write(SAMPLE_NET_V1) | ||
| distro = "fedora" if output_kind == "sysconfig" else "ubuntu" |
There was a problem hiding this comment.
Nit: Since fedora just switched to the network-manager renderer, maybe we should use a slower-moving distro for the sysconfig distro, such as CentOS?
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Checklist: