Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run github actions on pull request (SC-1094) #1496

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Only run github actions on pull request (SC-1094) #1496

merged 1 commit into from
Jun 7, 2022

Conversation

TheRealFalcon
Copy link
Member

Is there a reason we want it enabled for push and not just for PRs?

@TheRealFalcon TheRealFalcon added the wip Work in progress, do not land label Jun 7, 2022
@TheRealFalcon TheRealFalcon changed the title Only run github actions on pull request Only run github actions on pull request (SC-1094) Jun 7, 2022
@TheRealFalcon TheRealFalcon removed the wip Work in progress, do not land label Jun 7, 2022
holmanb
holmanb approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No good reason +1

In my mind this was to let users see test results prior to submitting a PR, but since this is causing friction I don't see a reason to keep this around.

Thanks for this!

@holmanb holmanb merged commit a63fd31 into canonical:main Jun 7, 2022
@paride paride mentioned this pull request Jun 17, 2022
Merged
3 tasks
This was referenced May 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb holmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheRealFalcon @holmanb