Start removing dependency on six #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allowed simplification of the logic, as we will never encounter a non-string text type.
blackboxsw
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Changeset looks good, I'm not quite sure how we should track this, but we need to make sure we drop python-six as a package dependency from ubuntu/xenial|bionic|eoan debian/control files.
Maybe we add a #SRU_BLOCKER comment to debian/control in those branches for next SRU?
Merged
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloud-init master no longer supports Python 2, so we no longer need to depend on the six library. This PR drops the usage of six in some parts of the codebase, to start us down that path.
(It also sorts imports where I was touching them anyway.)