Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop most of the remaining use of six #179

Merged
merged 34 commits into from Jan 21, 2020
Merged

Drop most of the remaining use of six #179

merged 34 commits into from Jan 21, 2020

Conversation

OddBloke
Copy link
Collaborator

No description provided.

@OddBloke
cc_mcollective: drop six
46e2be9
@OddBloke
cc_chef: drop six
4c1f9c0
@OddBloke
cc_yum_add_repo: drop six
824dac9
@OddBloke
cc_yum_add_repo: drop Python 2-only import logic
c6a044c
@OddBloke
cc_ubuntu_advantage: drop six
f80753e
@OddBloke
cc_power_state_change: drop six
eb94039
@OddBloke
cc_power_state_change: sort imports
bf155ea
@OddBloke
cc_ntp: drop six
4a91cf1
@OddBloke
cc_ntp: sort imports
23ba24a
@OddBloke
cc_write_files: drop six
b111fa0
@OddBloke
cc_rsyslog: drop six
30bf940
@OddBloke
net/sysconfig: drop six
614c6e1
@OddBloke
net/sysconfig: sort imports
d7bb885
@OddBloke
network_state: drop six
0f2f9cf
@OddBloke
net/renderer: drop six
8021c38
@OddBloke
stages: drop six
6092090
@OddBloke
distros/parsers/sys_conf: drop six
7e0196a
@OddBloke
distros/freebsd: drop six
12097a0
@OddBloke
distros/__init__: drop six
a3664d6
@OddBloke
sources/tests/test_init: drop six and Py2-only tests
b621602
@OddBloke
sources/tests/test_oracle: drop six
1b69557
@OddBloke
distros/ug_util: drop six
76f9421
@OddBloke
tests/helpers: drop six
27347dc
@OddBloke
tests/unittests/test_merging: drop six
a098b32
@OddBloke
tests/unittests/test_log: drop six
0266855
@OddBloke
tests/unittests/test_log: sort imports
cdd1eb1
@OddBloke
tests/unittests/test_cli: drop six
105eded
@OddBloke
tests/unittests/test_cli: sort imports
a71b116
@OddBloke
tests/unittests/test_handler/test_handler_write_files: drop six
69e0ef3
@OddBloke
tests/unittests/test_handler/test_handler_write_files: sort imports
a7a9b98
@OddBloke
Copy link
Collaborator Author

This leaves just util.py to tackle, which has some logic which could be simplified with the removal of six, so I want to tackle that separately.

blackboxsw
blackboxsw approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knock 'em down.

@blackboxsw blackboxsw merged commit bb71a9d into canonical:master Jan 21, 2020
@blackboxsw blackboxsw mentioned this pull request May 29, 2020
Merged
This was referenced May 12, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackboxsw blackboxsw blackboxsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OddBloke @blackboxsw