Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyze/dump: refactor shared string into variable #350

Merged
merged 3 commits into from
May 12, 2020

Conversation

OddBloke
Copy link
Collaborator

@OddBloke OddBloke commented May 6, 2020

This was a minor cleanup suggested by Ryan in #346.

This was a minor cleanup suggested by Ryan in canonical#346.
@lucasmoura
Copy link
Contributor

LGTM

Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

@blackboxsw blackboxsw merged commit d10ce3e into canonical:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants