Ubuntu/devel #373
Ubuntu/devel #373
Conversation
canonical#343) And raise TypeError when subp called with no args, which more accurately mirrors normal behaviour: >>> from cloudinit.util import subp >>> subp() Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: subp() missing 1 required positional argument: 'args'
Create a schema object for the `apt_configure` module and
validate this schema in the `handle` function of the module.
There are some considerations regarding this PR:
* The `primary` and `security` keys have the exact same properties. I
tried to eliminate this redundancy by moving their properties to a
common place and then just referencing it for both security and
primary. Similar to what is documented here:
https://json-schema.org/understanding-json-schema/structuring.html
under the `Reuse` paragraph. However, this approach does not work,
because the `#` pointer goes to the beginning of the file, which is
a python module instead of a json file, not allowing the pointer to
find the correct definition. What I did was to create a separate dict
for the mirror config and reuse it for primary and security, but
maybe there are better approaches to do that.
* There was no documentation for the config `debconf_selections`. I
tried to infer what it supposed to do by looking at the code and the
`debconf-set-selections` manpage, but my description may not be
accurate or complete.
* Add a _parse_description function to schema.py to render multi-line
preformatted content instead of squashing all whitespace
LP: #1858884
This ensures that Travis will not kill our tests if fetching images is taking a long time. In implementation terms, this introduces a context manager which will spin up a multiprocessing.Process in the background and print a dot to stdout every 10 seconds. The process is terminated when the context manager exits. This also drop the use of travis_wait, which was being used to work around this issue.
We live in the future now.
We recently discovered that pylint is failing to report some errors when invoked across our entire codebase (see pylint-dev/pylint#3611). I've run pylint across every Python file under cloudinit/[0], and this commit fixes the issues so-discovered. [0] find cloudinit/ -name "*.py" | xargs -n 1 -t .tox/pylint/bin/python -m pylint
…#368) We are longer using lxd.readthedocs.io Signed-off-by: Thomas Parrott thomas.parrott@canonical.com
and slower. and since we're making it slower, let's cache it, in case boottime gets called more than once.
Specifically, ensure that given values are either strings, or arrays of strings.
There was a problem hiding this comment.
I have followed the step @blackboxsw pointed it out and the new upstream release seems okay for me. I tried to verify if the work we have done in this past commits are appearing in the new devel release. But is there a better to verify if everything is fine with the release ?
Also, my changelog was different from the one here. Mine only has the new upstrem release entry. The changelog here is created manually right ?
@TheRealFalcon @lucasmoura I should have read this more clearly, ultimately we assume that our new-upstream-snapshot automated tooling is generally correct and we should be able to generate comparable diffs for upload as different developers. What we are trying to avoid during review is the following:
I should have counseled on this in the request for review, I had originally intended this to be an opportunity to make sure we get either of your sbuild environments up and running and using the build-package script so that we can start getting either of you to attempt perform uploads which core developers can then sponsor. Ultimately, I think we can get you setup and running build-package on your own systems in the subsequent branches that I'll put up for SRU validation. (as we'll have 4 more branches like this to verify) |
Generally, we should make sure build-package (in uss-tableflip) can build this package from source.
|
Create a new upstream snapshot for upload to groovy
Steps to reproduce: