Fix pip-managed ansible on pip < 23.0.1 #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holmanb
commented
Sep 1, 2023
holmanb
force-pushed
the
holmanb/pip-version-gate
branch
from
b635abb
to
85fe9cf
Compare
blackboxsw
requested changes
Sep 1, 2023
There was a problem hiding this comment.
Hey @holmanb what o you think about an alternative approach to only append --break-system-packages if that EXTERNALLY-MANAGED marker file is present? This would work on all flavors of Ubuntu back to focal as we'd avoid adding the param unless the distro itself implements the PEP668 marker.
blackboxsw
reviewed
Sep 15, 2023
blackboxsw
requested changes
Sep 15, 2023
Co-authored-by: Chad Smith <chad.smith@canonical.com>
|
Thanks for the review @blackboxsw. Fixed according to your comment. |
TheRealFalcon
pushed a commit
to TheRealFalcon/cloud-init
that referenced
this pull request
Oct 24, 2023
Commit b417b21 broke pip-managed ansible with pip < 23.0.1 and fixed pip-managed ansible with pip >= 23.0.1. Gate the change by a filesystem artifact only found on newer pip versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Context
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-lxd_vm/303/testReport/junit/tests.integration_tests.modules/test_ansible/test_ansible_controller/