sources: do not override datasource detection if None is in list #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjp256
commented
Sep 11, 2023
•
cjp256
commented
cjp256
force-pushed
the
source-detection
branch
from
3c0be01
to
1202ce1
Compare
Users with datasource_list = [Azure, None] started failing to boot properly outside of Azure with the changes to override datasource detection. If the fallback "None" is included in the datasource_list, do not treat the system as configured with a single datasource. If users want to force a single datasource regardless of detection, they can do so by removing None from the list. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
source-detection
branch
from
1202ce1
to
35988cc
Compare
holmanb
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
This makes sense. Checking for [Azure, "None"] was intended to avoid re-doing the datasource checks that ds-identify already does, but if this breaks a migration path that we'd like to support then I don't think this optimization makes sense.
Thanks for fielding this bug and providing a fix.
+1
12 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.