set_passwords: support for FreeBSD #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
migrated from https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/368507 from what i understand from @blackboxsw's comment here we still want to have his patch on top of it. |
|
The best is probably to use @blackboxsw patch directly. |
The www/chpasswd utility which we depended on for FreeBSD installations does *not* do the same thing as the equally named Linux utility. For FreeBSD, we now use the pw(8) utility (which can only process one user at a time) Additionally, we abstract expire passwd into a function, and override it in the FreeBSD distro class.
igalic
force-pushed
the
fix/fbsd-set_passwords
branch
from
495ad74
to
db36427
Compare
|
replaced @goneri's patch with @blackboxsw's. |
|
failing tests: |
igalic
commented
Nov 22, 2019
| @@ -179,20 +179,19 @@ def handle(_name, cfg, cloud, log, args): | |||
| for line in plist: | |||
| u, p = line.split(':', 1) | |||
| if prog.match(p) is not None and ":" not in p: | |||
There was a problem hiding this comment.
this means you can't have a : in your password
cloudinit/config/cc_set_passwords.py
Outdated
| randlist.append("%s:%s" % (u, p)) | ||
| plist_in.append("%s:%s" % (u, p)) | ||
| randlist.append(line) | ||
| plist_in.append(line) |
There was a problem hiding this comment.
is not reflected in these lists
There was a problem hiding this comment.
this hunk is now reverted
blackboxsw
requested changes
Nov 26, 2019
when `hashed` was false, the entire `cmd` is turned into `[]`. Co-Authored-By: Chad Smith <blackboxsw@gmail.com>
|
huh? i am honestly surprised you're passes now perhaps i need to add a test for random passwords |
blackboxsw
approved these changes
Nov 26, 2019
paride
pushed a commit
to paride/cloud-init
that referenced
this pull request
Nov 29, 2019
Allow setting of user passwords on FreeBSD The www/chpasswd utility which we depended on for FreeBSD installations does *not* do the same thing as the equally named Linux utility. For FreeBSD, we now use the pw(8) utility (which can only process one user at a time) Additionally, we abstract expire passwd into a function, and override it in the FreeBSD distro class. Co-Authored-By: Chad Smith <chad.smith@canonical.com>
This was referenced May 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FreeBSD support to
cc_set_passwords.FreeBSD does not come with chpasswd binary, a chpasswd port1 exists
but it's not the same tool than the one from Linux2.
Finally, NetBSD and OpenBSD don't have the chpasswd binary at all, so
an abstraction layer will be needed.