tests: Fix wsl test file mocks, set defaults for optional os-release fields #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting review from @rvandegrift and @CarlosNihelton. |
blackboxsw
requested changes
Mar 6, 2024
blackboxsw
reviewed
Mar 6, 2024
There was a problem hiding this comment.
Thanks @holmanb I added a diff suggestion unit test changes and a fallback to VERSION_CODENAME to help with debian /etc/os-release on trixie. let me know what you think
holmanb
force-pushed
the
holmanb/fix-ds-identify-wsl
branch
from
0687670
to
3e5c785
Compare
Looks good, that works for me! |
|
@holmanb thanks, works for me |
|
Thanks for the reviews @rvandegrift @blackboxsw @CarlosNihelton! |
holmanb
added a commit
to holmanb/cloud-init
that referenced
this pull request
Mar 9, 2024
Force ds-identify to use the correct file mocks Set defaults for optional os-release fields [1] VERSION_ID and ID might not be set; set defaults. [1] man 5 os-release Fixes canonicalGH-5002
holmanb
added a commit
to holmanb/cloud-init
that referenced
this pull request
Mar 9, 2024
Force ds-identify to use the correct file mocks Set defaults for optional os-release fields [1] VERSION_ID and ID might not be set; set defaults. [1] man 5 os-release Fixes canonicalGH-5002
holmanb
added a commit
to holmanb/cloud-init
that referenced
this pull request
Mar 9, 2024
Force ds-identify to use the correct file mocks Set defaults for optional os-release fields [1] VERSION_ID and ID might not be set; set defaults. [1] man 5 os-release Fixes canonicalGH-5002
catmsred
pushed a commit
to catmsred/cloud-init
that referenced
this pull request
Mar 11, 2024
Force ds-identify to use the correct file mocks Set defaults for optional os-release fields [1] VERSION_ID and ID might not be set; set defaults. [1] man 5 os-release Fixes canonicalGH-5002
holmanb
added a commit
that referenced
this pull request
Mar 11, 2024
Force ds-identify to use the correct file mocks Set defaults for optional os-release fields [1] VERSION_ID and ID might not be set; set defaults. [1] man 5 os-release Fixes GH-5002
holmanb
added a commit
to holmanb/cloud-init
that referenced
this pull request
Mar 12, 2024
Force ds-identify to use the correct file mocks Set defaults for optional os-release fields [1] VERSION_ID and ID might not be set; set defaults. [1] man 5 os-release Fixes canonicalGH-5002
holmanb
added a commit
that referenced
this pull request
Mar 12, 2024
Force ds-identify to use the correct file mocks Set defaults for optional os-release fields [1] VERSION_ID and ID might not be set; set defaults. [1] man 5 os-release Fixes GH-5002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Fixes GH-5002
Test Steps
Comment out
VERSION_IDin the host system's os-release file, runMerge type