chore(safeyaml): Remove legacy Python 2 unicode helper #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holmanb
force-pushed
the
holmanb/drop-old-yaml
branch
from
7a416a6
to
a23dd61
Compare
holmanb
force-pushed
the
holmanb/drop-old-yaml
branch
from
a23dd61
to
774c89e
Compare
holmanb
changed the title
|
Tested with tests and they all passed. I will be testing the package built. |
Thanks for the review @CalvoM! |
TheRealFalcon
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Note that the unittests that were added with this helper back in the python2 days still pass.
Rational: custom code that offers nothing over library code is an unnecessary complexity, remove it.