Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mock internet access in test_upgrade #5212

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Apr 25, 2024

Proposed Commit Message

test: mock internet access in test_upgrade

Fixes: #5211

Additional Context

Test Steps

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@aciba90 aciba90 requested a review from CalvoM April 25, 2024 11:32
@holmanb holmanb self-assigned this Apr 25, 2024
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @aciba90!

Unfortunately this might crop again since I don't think we test anything like this. Perhaps an lxd integration test which takes down the network and then runs the unittests would help us prevent this from happening again?

@TheRealFalcon TheRealFalcon merged commit aeafb83 into canonical:main Apr 26, 2024
29 checks passed
@TheRealFalcon
Copy link
Member

@holmanb , good idea. I opened #5220 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants