Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Fix TestFTP integration test SC-1779 #5237

Merged
merged 1 commit into from
May 8, 2024

Conversation

CalvoM
Copy link
Contributor

@CalvoM CalvoM commented Apr 30, 2024

There seems to be a jenkins proxy issue with the test software.sslmate.com had an issue with the jenkins proxy

Proposed Commit Message

Additional Context

Test Steps

CLOUD_INIT_PLATFORM=lxd_vm CLOUD_INIT_OS_IMAGE=jammy CLOUD_INIT_KEEP_INSTANCE=True tox -e integration-tests -- tests/integration_tests/datasources/test_nocloud.py::TestFTP::test_nocloud_ftps_encrypted_server_succeeds
CLOUD_INIT_PLATFORM=lxd_vm CLOUD_INIT_OS_IMAGE=jammy CLOUD_INIT_CLOUD_INIT_SOURCE=ppa:cloud-init-dev/daily tox -e integration-tests -- tests/integration_tests/datasources/test_nocloud.py::TestFTP::test_nocloud_ftp_encrypted_server_fails

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@CalvoM CalvoM force-pushed the fix_testftp_tests branch 2 times, most recently from b7c733e to 21959b7 Compare April 30, 2024 12:40
@CalvoM CalvoM marked this pull request as draft April 30, 2024 14:24
@TheRealFalcon
Copy link
Member

@CalvoM , this PR is still in draft state. Is it still in development? If not, you'll want to remove the draft state.

@CalvoM CalvoM marked this pull request as ready for review May 7, 2024 14:17
@CalvoM
Copy link
Contributor Author

CalvoM commented May 7, 2024

Oh it is ready for review.

There seems to be a jenkins proxy issue with the test

software.sslmate.com had an issue with the jenkins proxy
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit dd54327 into canonical:main May 8, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants