Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freebsd): correct configuration of IPv6 routes #5291

Merged
merged 1 commit into from
May 29, 2024

Conversation

frikilax
Copy link
Contributor

@frikilax frikilax commented May 14, 2024

Proposed Commit Message

fix(freebsd): correct configuration of IPv6 routes

the generation of IPv6 routes on FreeBSD were not correct.
This commit keeps the generation of IPv4 routes as they were, but introduces a change to parameter names and separate handling of IPv6 routes

Additional Context

This only impacts Networking Config v1 on FreeBSD, and nothing was changed regarding other *BSD distros.

Test Steps

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb added the CLA signed The submitter of the PR has signed the CLA label May 15, 2024
@holmanb holmanb requested a review from igalic May 15, 2024 07:07
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@TheRealFalcon TheRealFalcon merged commit 00ab328 into canonical:main May 29, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed The submitter of the PR has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants