fix(lxd): Properly handle unicode from LXD socket #5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
reviewed
May 22, 2024
There was a problem hiding this comment.
functionally looks good.
I think we are missing correct mocks here in tests/unittests/sources/test_lxd.py::TestReadMetadata::test_read_metadata_handles_unexpected_content_or_http_status as we are failing on our mock here in py 3.11 due to our mocking of response.text instead of response.content. May need to update that unittest to avoid the 8 failures there.
|
Doh, I missed the unit test failures. Thanks! Should be updated now. |
blackboxsw
approved these changes
May 23, 2024
| @@ -506,6 +507,10 @@ def test_instance_cloud_id_across_reboot( | |||
| assert client.execute(f"test -f /run/cloud-init/{cloud_file}").ok | |||
| assert client.execute("test -f /run/cloud-init/cloud-id").ok | |||
|
|
|||
| def test_unicode(self, class_client: IntegrationInstance): | |||
| client = class_client | |||
| assert "💩" == client.read_from_file("/var/tmp/unicode_data") | |||
There was a problem hiding this comment.
And, who says we don't know how to have fun in this project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
See #5300
Merge type