Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): disable use-dns for secondary nics #5314

Merged
merged 1 commit into from
May 29, 2024

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented May 22, 2024

Proposed Commit Message

fix(azure): disable use-dns for secondary nics

DNS resolution through secondary NICs is not supported on Azure. Disable
it.
    
Without this, we see seconds of delay resolving urls in cloud-init logs
from Jammy+, see SF ticket.
    
Per cjp256's comment, the first NIC under metadata.imds.network is ensured
to be the primary one. We use this to determine primary NICs instead of
relying on fragile driver and/or NIC names.
    
Fixes: SF #00380708
    
Co-authored-by: Calvin Mwadime <calvin.mwadime@canonical.com>

Additional Context

Supersedes #5180, see comments for more context.
Closes:

Test Steps

make deb

export CLOUD_INIT_CLOUD_INIT_SOURCE=cloud-init_all.deb
export CLOUD_INIT_PLATFORM=azure

tox -e integration-tests -- tests/integration_tests/datasources/test_azure.py::test_azure_multi_nic_setup

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • [] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@aciba90
Copy link
Contributor Author

aciba90 commented May 22, 2024

@danpdraper and @cjp256, I have created this PR superseding #5180. Please review it, thanks.

Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!! I'll be sure to verify when it lands in the daily.

DNS resolution through secondary NICs is not supported on Azure. Disable
it.

Without this, we see seconds of delay resolving urls in cloud-init logs
from Jammy+, see SF ticket.

Per cjp256's comment, the first NIC under metadata.imds.network is ensured
to be the primary one. We use this to determine primary NICs instead of
relying on fragile driver and/or NIC names.

Fixes: SF: #00380708

Co-authored-by: Calvin Mwadime <calvin.mwadime@canonical.com>
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aciba90 aciba90 merged commit 42930d8 into canonical:main May 29, 2024
27 of 29 checks passed
@aciba90 aciba90 deleted the multi_nic_netplan_azure branch May 29, 2024 07:10
@cjp256
Copy link
Contributor

cjp256 commented Jun 3, 2024

Just wanted to say thanks again @aciba90! Testing looks great so far.

@aciba90
Copy link
Contributor Author

aciba90 commented Jun 4, 2024

Thank you, @cjp256, for the support and testing! Let us know if anything goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants