Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update schema validation error in integration test #5429

Merged
merged 1 commit into from
Jun 21, 2024
Merged

test: Update schema validation error in integration test #5429

merged 1 commit into from
Jun 21, 2024

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

test: Update schema validation error in integration test

Message changed in 9c3258f4

Additional Context

#5404

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@TheRealFalcon TheRealFalcon marked this pull request as draft June 21, 2024 21:15
@TheRealFalcon
Copy link
Member Author

(in draft as we have another failing test with the same message)

blackboxsw
blackboxsw approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated failure and fix with the following. LGTM!

 CLOUD_INIT_PLATFORM=lxd_container CLOUD_INIT_OS_IMAGE=oracular CLOUD_INIT_CLOUD_INIT_SOURCE=IN_PLACE tox -e integration-tests -- tests/integration_tests/cmd/test_status.py

@TheRealFalcon TheRealFalcon marked this pull request as ready for review June 21, 2024 21:20
@TheRealFalcon
Copy link
Member Author

I'm going to go ahead and merge this one as-is, as the other test failure also includes a return code change, which may be longer to track down.

@TheRealFalcon TheRealFalcon merged commit ccf5850 into canonical:main Jun 21, 2024
23 checks passed
@TheRealFalcon TheRealFalcon deleted the validation-message branch June 21, 2024 21:22
holmanb pushed a commit that referenced this pull request Jun 28, 2024
@TheRealFalcon @holmanb
test: Update schema validation error in integration test (#5429)
4de14d9 
Message changed in 9c3258f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackboxsw blackboxsw blackboxsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheRealFalcon @blackboxsw