Fix Gentoo hostname bug #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gentoo's hostname file format instead of being just the host name is hostname=thename". The old code works fine when the file has no comments but if there is a comment the line ``` gentoo_hostname_config = 'hostname="%s"' % conf ``` can render an invalid hostname file that looks similar to ``` hostname="#This is the host namehello" ``` The fix inserts the hostname in a gentoo friendly way so that it gets handled by HostnameConf as a whole and comments are handled and preserved
manuelisimo
force-pushed
the
gentoo-hostname-fix
branch
from
5e707dc
to
4ec8df8
Compare
|
Re-based branch and fixed flake8 issue |
TheRealFalcon
approved these changes
Oct 26, 2020
OddBloke
approved these changes
Oct 27, 2020
| @@ -13,6 +13,7 @@ johnsonshi | |||
| jqueuniet | |||
| landon912 | |||
| lucasmoura | |||
| manuelisimo | |||
There was a problem hiding this comment.
I've confirmed this signature internally, thanks!
|
|
||
| # Many distro's format is the hostname by itself, and that is the | ||
| # way HostnameConf works but gentoo expects it to be in | ||
| # hostname="the-actual-hostname" |
There was a problem hiding this comment.
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gentoo's hostname file format instead of being just the host name by itself is
hostname="thename". The existing code works fine when the file has no comments but if there is a comment, then the line:can render an invalid hostname file that looks similar to
The fix calls
set_hostnamewith the parameter in a gentoo friendly way so that it gets handled by HostnameConf as a whole, and comments are handled and preserved