-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v1 and v2 network config docs to clarify MAC addresses #623
Update v1 and v2 network config docs to clarify MAC addresses #623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for chasing this all down, Dermot, it's been quite the adventure! If we're ever at a conference together, I owe you 00:00:00:00:00:01 beverages of your choosing. (I have a couple of thoughts inline.)
09e3431
to
ccb28f5
Compare
…ould be quoted. Also update MAC addresses used in testcases to remove quotes where not required and add single quotes where quotes are required.
ccb28f5
to
278a160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙋🏻♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one minor formatting issue. I'll apply that fix then land this. Thank you!
Proposed Commit Message
Update v1 and v2 network config docs to clarify when MAC addresses should be quoted.
Also update MAC addresses used in testcases to remove quotes where not
required and add single quotes where quotes are required.
Additional Context
MAC addresses consisting of only 0-9 digits may be misintepreted as YAML Base 60 numbers if not quoted.
See YAML reference for definition of a Base 60 number.
Test Steps
Existing testcases are adequate.
Checklist: