Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch_kwargs bug in integration tests #654

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

Fix launch_kwargs bug in integration tests

Integration test instance launch would previously fail if provided
launch_kwargs is None

Additional Context

None

Test Steps

pytest tests/integration_tests/

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Integration test instance  launch would previously fail if provided
launch_kwargs is None
Copy link
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@OddBloke OddBloke merged commit f423597 into canonical:master Nov 4, 2020
@TheRealFalcon TheRealFalcon deleted the launch-kwargs branch June 29, 2021 18:59
This was referenced May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants