Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: correctly integration test the built .deb #683

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

OddBloke
Copy link
Collaborator

Proposed Commit Message

.travis.yml: correctly integration test the built .deb

IMAGE_SOURCE was renamed to CLOUD_INIT_SOURCE before the testing
framework ever landed, but I did not mirror that change in .travis.yml
before it landed. This addresses that.

Test Steps

Travis output should be inspected to confirm the built .deb is being used, something like:

CLOUD_INIT_SOURCE=cloud-init_20.3-103-gb07ec7d3-1~bddeb~16.04.1_all.deb

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

`IMAGE_SOURCE` was renamed to `CLOUD_INIT_SOURCE` before the testing
framework ever landed, but I did not mirror that change in .travis.yml
before it landed.  This addresses that.
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns w/ variable naming (and expected environment prefix) https://github.com/canonical/cloud-init/blob/master/tests/integration_tests/integration_settings.py#L56. Ran through a test run setting this value to confirm expected behavior.

@blackboxsw blackboxsw merged commit 66a851a into master Nov 23, 2020
@OddBloke OddBloke deleted the tests branch November 23, 2020 17:20
This was referenced May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants