Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox: avoid tox testenv subsvars for xenial support #684

Merged

Conversation

blackboxsw
Copy link
Collaborator

@blackboxsw blackboxsw commented Nov 23, 2020

Proposed Commit Message

Commit cd752df added substvars in tip which causes tracesbacks
on Xenial because tox 2.3.1 still suffers from
tox-dev/tox#208.

As a result we cannot use testenv substvars if we want to support
running tox on xenial systems.

Drop the {[testenv:integration-tests]*} substitutions to avoid
tracebacks when running tox -e xenial-dev which has the signature:

"No support for the %s substitution type" % sub_type)
tox.ConfigError: ConfigError: No support for the posargs
substitution type

Additional Context

None

Test Steps

cat > doit.sh <<EOF
git clone https://github.com/canonical/cloud-init
apt-get update
apt-get install tox -y
cd cloud-init
tox -e xenial-dev
EOF
lxc launch ubuntu-dialy:xenial test-x
lxc file push doit.sh test-x/
lxc exec test-x -- bash  /doit.sh


# note exception

Apply this patch.
re-run tox -e xenial-dev

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly N/A
  • I have updated or added any documentation accordingly N/A

Xenial tox 2.3.1 still suffers from
    tox-dev/tox#208.

As a result we cannot use testenv substvars if we want to support running
tox on xenial systems.

Drop the {[testenv:integration-tests]*} substitutions to avoid tracebacks
when running `tox -e xenial-dev` which has the signature:

   "No support for the %s substitution type" % sub_type)
   tox.ConfigError: ConfigError: No support for the posargs substitution
   type
Copy link
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OddBloke OddBloke merged commit 87df9d6 into canonical:master Nov 24, 2020
This was referenced May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants