HACKING.rst: add clarifying note to LP CLA process section #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had some first time contributors still end up trying to submit via Launchpad: this commit underlines that this is not necessary.
TheRealFalcon
approved these changes
Jan 26, 2021
mitechie
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
After going through the process I think that changing the title of this section to set the condition scope would be useful.
e.g.
Transferring CLA Signatures from Launchpad to Github
to perhaps
If you previously signed the CLA through Launchpad...
Which helps set the optional/condition of this section upfront.
The note in this PR is +1 either way.
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Test Steps
Build the docs and observe:
Checklist: