Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port apt cloud_tests to integration tests #808

Merged
merged 4 commits into from Feb 17, 2021

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

Port apt cloud_tests to integration tests

Additional Context

This should cover all of the apt_*.py test cases currently in the cloud tests. I ported things as close to 1:1 as possible, but added some different PPA sources to ensure a source from one test wasn't affected a check in another.

I also question the value of a couple of these tests. In particular, the ones under TestDefaults, and wondering if we need 3 different tests for what's in test_key, test_keyserver, and test_ppa. I think it's fine to keep them, but if reviewers have strong opinions on deleting anything, let me know.

Test Steps

pytest tests/integration_tests/modules/test_apt.py

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I appreciate reducing and consolidating the test cases anywhere we have the ability to test non-conflicting features. Integration tests are too time/CPU costly for setup/teardown to not leverage some of that setup for multiple tests where applicable. Even in the test/cloud_tests we talked about trying to combine some tests that would not be destructive for other feature tests. Expedite test where we can and where it doesn't cause us problems in terms of getting a valid signal on a test failure.

tests/integration_tests/modules/test_apt.py Outdated Show resolved Hide resolved
tests/integration_tests/modules/test_apt.py Outdated Show resolved Hide resolved
@blackboxsw blackboxsw merged commit 7f1cefe into canonical:master Feb 17, 2021
@TheRealFalcon TheRealFalcon deleted the apt-tests branch August 19, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants