Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration_tests: fix test_gh626 on LXD VMs via SSH #809

Merged
merged 2 commits into from Feb 16, 2021

Conversation

OddBloke
Copy link
Collaborator

Proposed Commit Message

integration_tests: fix test_gh626 on LXD VMs via SSH

Without a MAC address match clause, the test network configuration is
not applied to the primary interface in LXD VMs (which is named enp*s*
rather than eth0). This means that networking does not come up, so
SSH access is not possible.

Test Steps

Run the test on a LXD VM (with either an SSH key configured, or with the new pycloudlib which uses SSH by default) and observe success.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Without a MAC address match clause, the test network configuration is
not applied to the primary interface in LXD VMs (which is named enp*s*
rather than eth0).
@OddBloke
Copy link
Collaborator Author

This test has the same bug that all other tests which are setting a MAC address do: it uses the same MAC address everywhere, so if instances from previous runs are around or tests are being run in parallel, failures will be observed due to traffic being routed to the "wrong" DE:AD:BE:EF:12:34 interface.

I'll address that generally in a follow-up.

@OddBloke OddBloke merged commit 85e88af into canonical:master Feb 16, 2021
@OddBloke OddBloke deleted the tests2 branch February 16, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants