Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chef apt source #826

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Fix chef apt source #826

merged 3 commits into from
Mar 24, 2021

Conversation

timothegenzmer
Copy link
Contributor

@timothegenzmer timothegenzmer commented Feb 25, 2021

Proposed Commit Message

Fix chef apt source

summary: Fix chef apt source

key is a property of source1 and not sources

Additional Context

Test Steps

try to add a apt repository with the old docs
apt repository wont be added

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! Before we can get this merged, you need to add your name to the CLA signers file. As part of this PR, please add your name (alphabetically) to https://github.com/canonical/cloud-init/blob/master/tools/.github-cla-signers . The full details are described in the last bullet point here: https://cloudinit.readthedocs.io/en/latest/topics/hacking.html#submitting-your-first-pull-request

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.4.12 (Darwin)
Comment: GPGTools - http://gpgtools.org

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this line shouldn't have the additional whitespace.

@github-actions
Copy link

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Mar 18, 2021
@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Mar 24, 2021
@TheRealFalcon TheRealFalcon merged commit d4acc09 into canonical:master Mar 24, 2021
@timothegenzmer timothegenzmer deleted the patch-1 branch March 25, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants