Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Doc Update for ReportEventStack and Test #920

Conversation

irishgordo
Copy link
Contributor

@irishgordo irishgordo commented Jun 15, 2021

Proposed Commit Message

  • small document update for ReportEventStack explaining post_files
    parameter
  • small unit test for test_reporting demonstrating the close of an
    event with optional post_files list

Summary

Hey there, this project is rad! Trying to wrap my head around bits of it here and there, very greenhorn still haha. Thought there might be a slight benefit to a little more documentation surrounding an optional list parameter. Added an additional little test for small additional gain of test coverage and demonstration.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

- small document update for ReportEventStack explaining post_files
parameter
- small unit test for test_reporting demonstrating the close of an
event with optional post_files list

Resolves: docs/reporting-events-doc-update-and-test
@irishgordo
Copy link
Contributor Author

irishgordo commented Jun 15, 2021

Also, not entirely sure how to tie Launchpad stuff to GitHub, but for-what-its-worth, I do have a Launchpad account here:

https://launchpad.net/~irishgordo

@TheRealFalcon
Copy link
Member

Hey @irishgordo , thanks for this change!

In order to accept your change, you need to sign the CLA and add your Github username (alphabetically) to the cla signers file . The full details are described in the last bullet point here: https://cloudinit.readthedocs.io/en/latest/topics/hacking.html#submitting-your-first-pull-request

You don't need to worry about the launchpad stuff.

- added irishgordo GitHub UserName alphabetically to CLA Signers

Resolves: docs/reporting-events-doc-update-and-test
@irishgordo
Copy link
Contributor Author

@TheRealFalcon
Thanks for the info!
Sorry about the oversight with the CLA Signers File and CLA, pushed up another commit that possesses the change.

Glad I could help, I'm super game to make any adjustments if needed as well with the additional test or doc update too.
Always wanna make sure info and whatnot makes sense haha 😆

Thanks again for the quick response and the approval!

@TheRealFalcon TheRealFalcon merged commit c8d3f99 into canonical:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants