Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_tests: add impish release definition #927

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

paride
Copy link
Contributor

@paride paride commented Jun 18, 2021

Proposed Commit Message

cloud_tests: add impish release definition

Additional Context

Spotted in our integration testing.

Test Steps

On main:

$ python3 -m tests.cloud_tests run --os-name=impish --platform=nocloud-kvm --preserve-data --data-dir=results --verbose                                2021-06-18T16:06:28 CEST
usage: cloud_tests run [-h] [-p PLATFORM] [-n NAME] [-t FILE] [--feature-override FEATURE_OVERRIDE] [-v] [-q] [-r FILE] [-d DIR] [--preserve-instance] [--preserve-data] [--deb FILE] [--rpm FILE] [--script DATA]
                       [--repo NAME] [--ppa NAME] [-u] [--upgrade-full]
cloud_tests run: error: argument -n/--os-name: invalid choice: 'impish' (choose from 'artful', 'bionic', 'centos66', 'centos70', 'cosmic', 'disco', 'eoan', 'focal', 'groovy', 'hirsute', 'jessie', 'stretch', 'trusty', 'xenial')

With this PR:

$ python3 -m tests.cloud_tests run --os-name=impish --platform=nocloud-kvm --preserve-data --data-dir=results --verbose              2021-06-18T16:07:07 CEST
2021-06-18 14:07:09,141 - /home/paride/ubuntu/git/cloud-init/tests/cloud_tests/__main__.py:main:54 [DEBUG]: running with args: [...]

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@TheRealFalcon TheRealFalcon merged commit f5a2449 into canonical:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants