Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed distro specific network code from Photon #929

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

sshedi
Copy link
Contributor

@sshedi sshedi commented Jun 22, 2021

Minor fixes in networkd renderer & fixed corresponding tests

Signed-off-by: Shreenidhi Shedi sshedi@vmware.com

Proposed Commit Message

Removed distro specific network code from Photon

Minor fixes in networkd renderer & fixed corresponding tests

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@sshedi
Copy link
Contributor Author

sshedi commented Jun 22, 2021

Hi @TheRealFalcon - like we discussed during 1st PR, I have removed the _write_network_ and related functions.
Also fixed few issues in networkd. Please review whenever you get time.

@sshedi sshedi force-pushed the photon branch 2 times, most recently from 7345b4c to 2518f1b Compare June 25, 2021 10:21
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I've left a few comments inline.

cloudinit/net/networkd.py Show resolved Hide resolved
cloudinit/net/networkd.py Outdated Show resolved Hide resolved
Minor fixes in networkd renderer & fixed corresponding tests

Removed datasource_list for Photon from cloud.cfg.tmpl & added a comment
in cloud.cfg.tmpl about not to use multiline array for datasource_list.

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit b5aecbe into canonical:main Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants